streamline parents lookup per run. #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/models/bulkrax/importer_run.rb # app/models/concerns/bulkrax/import_behavior.rb # db/migrate/20220301020307_add_parents_to_bulkrax_importer_runs.rb
alishaevn
reviewed
Apr 13, 2022
| @@ -5,6 +5,8 @@ class ImporterRun < ApplicationRecord | |||
| belongs_to :importer | |||
| has_many :statuses, as: :runnable, dependent: :destroy | |||
|
|
|||
| serialize :parents, Array | |||
| def parents | |||
There was a problem hiding this comment.
does this get called now with importer.last_run.parents in the schedule relationships job?
alishaevn
reviewed
Apr 13, 2022
| @@ -5,6 +5,8 @@ class ImporterRun < ApplicationRecord | |||
| belongs_to :importer | |||
| has_many :statuses, as: :runnable, dependent: :destroy | |||
|
|
|||
| serialize :parents, Array | |||
| def parents | |||
There was a problem hiding this comment.
does this get called now with importer.last_run.parents in the schedule relationships job?
There was a problem hiding this comment.
yes; that is the idea at least.
alishaevn
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove database column for parents and just use relationships look up each time.